Add cancel button to 'Do you want to save?' message box #1185
+43
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1183 by adding a cancel button to the 'Do you want to save?' message box.
Overall the MessageBox looks like this now:
From a technial point of view I introduced a new enum
MessageBoxResultrepresenting the return values of a MessageBox.This enum is intended to pursue the idea of the
IMessageBoxinterface further: hiding the implementation details of the Windows Forms MessageBox to the caller.So far a boolean return value was sufficient for all methods of the IMessageBox interface - however the new method
YesNoCancelrequires more than a boolean state - do I decided to use that enum.